[wxPython-users] CustomTreeCtrl Patches

[Rooney, Mike (ext. 324)]

This along with the treemixin are AMAZING, thanks!!!

I applied your patch (manually, what program can I use to do this automatically
to a local file?). Our UnselectAll issues are fixed, so that is good. Our
styles were also greatly cleaned up as result, we had a lot of places where we
passed wx.TR_XXX into the style, and CT.TR_XXX into the ctstyle, unsure of what
we needed to do. I removed all wx.TR_XXX styles and am only using CT styles,
this is okay, right? Seems to work fine. I have experienced no bugs and all our
unit tests pass, so on my end the patch is good.

One question though, awhile ago you had given us a fix of:

        self.CalculatePositions()
        self.HideWindows()

when controls were showing up weird, but said you were looking into a better
solution. Is this still necessary? We have this scattered around and I was just
curious.

I hope it is also okay to talk about how great the treemixin is here. I used
the ExpansionState mixin and was able to clean up our code, remove some
unnecessary methods, AND increase peformance. What a great mixin, thanks Andrea
and Frank.

Any luck on the multiple dragging support in the DragAndDrop mixin? I see
treemixin was included in the latest wxPython release (congrats!), but if it isn't
working there I won't bother upgrading as I would still have to maintain my own
copy of the mixin anyway. Otherwise I will upgrade wxPython when this patch
is integrated into it. Thanks again, wonderful work!

- Mike

-----Original Message-----
From: Andrea Gavana [mailto:andrea.gavana at gmail.com]
Sent: Friday, March 02, 2007 2:10 PM
To: wxPython-users at lists.wxwidgets.org
Subject: [wxPython-users] CustomTreeCtrl Patches


Hi All,

    following the bug reports (mainly from Frank), attached you'll
find the patch, for the main script and for the demo, made against
CVS. I hope Robin will integrate it in the next wxPython release. The
patch fixes the following problems/bugs/inconsistencies:

1) ExpandAll has been renamed as ExpandAllChildren, and the new
ExpandAll now takes no input arguments (consistent with wx.TreeCtrl);
2) ctstyle keyword is now defaulted to 0: every style related to
CustomTreeCtrl and the underlying wx.PyScrolledWindow should be
declared using the keyword "style" only. For backward compatibility,
ctstyle continues to work as I merged ctstyle and style in the
__init__ method;
3) GetClassDefaultAttributes is now a classmethod;
4) UnselectAll bug fixed.

I have no still no idea on what to do about the item fonts (Frank, any news?).

If there are volunteers to test the modifications, please report any
stupid mistake I may have made.

Andrea.

"Imagination Is The Only Weapon In The War Against Reality."
http://xoomer.virgilio.it/infinity77/