[wxPython-dev] img2py script

[Anthony Tuininga]

On Nov 20, 2007 12:20 PM, Robin Dunn <robin at alldunn.com> wrote:
> Yes, please do provide a patch.  Some comments:
>
> * The name of the class should be something like PyEmbeddedImage because
> the naming convention used elsewhere of PySomething where Something is a
> C++ class usually means that PySomething is a wrapper that knows how to
> redirect C++ virtual method calls to Python methods.  Since this is not
> the case here it should have a more unique name.

Sure. That makes sense to me.

> * There should be a GetIcon method.

Ok.

> * You could also provide properties for these getter methods, (Bitmap =
> property(GetBitmap), etc.)

That could prove convenient. I'll add that as well.

> * Since the data string is inside () you don't need the \ at the end of
> the lines.

Yes, I figured that out already. :-)

> * Please also change the various places in the wx.lib packages that use
> embedded images and make that part of the patch too.

Sure. That makes sense.

Unless I hear otherwise I'll assume that patches against the 2.8
branch work for you. I'll send one further e-mail with a link to the
tracker when I've got something I think is worth looking at. Thanks.

Anthony