[2.8.0] wxSizerFlag and missing methods

[Vadim Zeitlin]

On Tue, 30 Jan 2007 23:07:02 +0100 H <H at h.com> wrote:

H> > H>  - Top() {return Align(wxALIGN_TOP);}
H> > H>  - Bottom() {return Align(wxALIGN_BOTTOM);}
H> > 
H> >  Those could be added for symmetry with Left/Right() I guess although I
H> > think they're far less common.
H> 
H> I think they should be added because otherwise wxSizerFlags is less 
H> intuitive.

 Ok, added them.

H> > H>  - CenterHorizontal() {return (wxALIGN_CENTER_HORIZONTAL);}
H> > H>  - CenterVertical() {return (wxALIGN_CENTER_VERTICAL);}
H> > 
H> >  I wonder if we shouldn't just make alignment (at least when using
H> > wxSizerFlags?) CENTRE by default. Then those wouldn't be necessary.
H> 
H> I do not recommend this because the default wxSizerFlags settings should 
H> be identical to the default individual settings, means
H> 
H> wxSizer::Add(wxWindow*, int proportion, int flags, int border)
H> 
H> ==
H> 
H> wxSizer::Add(wxWindow*, wxSizerFlags)

 Probably a good point. Still, I don't think we should necessarily provide
individual methods for all possible horizontal and vertical alignment flags
combinations so I hesitate to add those.

 Regards,
VZ

-- 
TT-Solutions: wxWidgets consultancy and technical support
               http://www.tt-solutions.com/