wxFrameBase::DoGiveHelp fix for Bug 1340887 incomplete

[Matthias Reitberger]

Vadim Zeitlin schrieb:
> On Mon, 02 Apr 2007 15:50:33 +0200 Matthias Reitberger <matthias.reitberger at mecadtron.de> wrote:
>
> MR> Vadim Zeitlin schrieb:
> MR> > MR> Now I sometimes get back no status text when using the menubar, but that 
> MR> > MR> isn't as bad as getting back an outdated status text.
> MR> >
> MR> >  Sorry, I don't understand how does this happen. Would you have a patch
> MR> > against the toolbar sample showing it?
> MR> >   
> MR> You can use the toolbar sample as it is:
> MR> 1. Start the sample, the status text says 'Hello, wxWidgets'
> MR> 2. Now go to the Menubar and click on 'Help' to display the help menu.
> MR> 3. Click again on 'Help' to undisplay the help menu.
> MR> 4. Move the Mouse back inside the frame, no status text is displayed.
>
>  Thanks, I do indeed the problem (in fact it can be seen even in the
> minimal sample, or just about any other one, I don't know why did I think
> it was specific to the toolbars). It should be fixed in the latest cvs,
> please let me know if you still see any problems.
>
>  Thanks,
> VZ
>
>   
After testing some more with the toolbar sample, I think we are back to 
where we started from.
It now works for the menubar but not for the toolbar. When leaving the 
toolbar, /wxToolBarBase::OnMouseEnter( -1 ) / is called.
This results in a call to /wxFrameBase::DoGiveHelp/ with empty help 
string, which is set in the statusbar.
Only /wxFrameBase::OnMenuClose /restores the /m_oldStatusText/, leaving 
the toolbar doesn't.
You can see this in the toolbar sample, just enter the toolbar with the 
mouse and leave it again.
The status text is gone, however you can bring it back by opening and 
closing a menu.

Greetings

Matthias