[wx-dev] Mac wxSpinCtrl vs generic version

[Stefan Csomor]

Hi

On 18.03.08 04:48, "Vadim Zeitlin" <vadim at wxwidgets.org> wrote:

>  Hello,
> 
>  Does anyone know if there any important differences between
> src/mac/carbon/spinctrl.cpp and src/generic/spinctlg.cpp? They have
> obviously started from the same version but Mac version is now quite
> different from the generic one and while it has some improvements compared
> to it (notably event generation from EVT_TEXT and EVT_KILL_FOCUS handlers)
> it also lacks many fixes done in the generic version since the separation.
> So I think we should merge them but I'd appreciate any hints to the changes
> which are really important.
> 
>  One of them seems to be setting m_macIsUserPane to true before calling
> base class Create() but I don't really know what does this do and whether
> there is any way to do it in a portable way in order to avoid __WXMAC__
> #ifdefs in the generic code.

it is not needed as it is set to true by default (meaning the base Create
does create a native 'UserPane' control as counter part), it is only set to
false for native controls, where there is no need to have this 'stand-in'

> 
>  OTOH I don't know if the other changes in Create() are really needed, does
> anybody know?

just try without to see whether the layout of the controls really looks ok

Best,

Stefan