[ wxwindows-Patches-1783181 ] MSW: wxToolBar background colour on XP (Zune)

[SourceForge.net]

Patches item #1783181, was opened at 2007-08-28 12:37
Message generated for change (Comment added) made by vadz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1783181&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: MSW specific
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: troelsk (troelsk)
Assigned to: Nobody/Anonymous (nobody)
Summary: MSW: wxToolBar background colour on XP (Zune)

Initial Comment:
See
[BUG 1782487 ] MSW: wxToolBar background colour on XP
(Zune Desktop Theme)

Patch:
Do as in wxToolBar::OnSysColourChanged on initialization also.

Problem seen, and seen go away with the patch, with wxMSW 2.8.5 rc3 on WinXP SP2


----------------------------------------------------------------------

>Comment By: Vadim Zeitlin (vadz)
Date: 2008-03-03 00:28

Message:
Logged In: YES 
user_id=71618
Originator: NO

It looks like the (only) reason this patch works is because it forces us
to always draw the background ourselves. I've modified the trunk sources to
always do it under XP, let's see if this has any ill side effects. I tested
that it fixed this particular bug, anyhow.

----------------------------------------------------------------------

Comment By: troelsk (troelsk)
Date: 2007-12-07 16:06

Message:
Logged In: YES 
user_id=1290727
Originator: YES


>I still don't understand why is this needed.

Me neither. It is a bit of a mystery.



----------------------------------------------------------------------

Comment By: Vadim Zeitlin (vadz)
Date: 2007-12-04 02:31

Message:
Logged In: YES 
user_id=71618
Originator: NO

I still don't understand why is this needed... the toolbar should paint
the background with the default background brush by default anyhow so why
do we need to call SetBackgroundColour() explicitly?

----------------------------------------------------------------------

Comment By: troelsk (troelsk)
Date: 2007-12-03 10:50

Message:
Logged In: YES 
user_id=1290727
Originator: YES


tbar95.cpp revision 50431 makes this issue arise again, if using XP with
Zune, I don't know about Silver.

(bad toolbar background in toolbar sample, buttons and controls has
different background colors)


----------------------------------------------------------------------

Comment By: troelsk (troelsk)
Date: 2007-08-30 10:24

Message:
Logged In: YES 
user_id=1290727
Originator: YES

tbar95.cpp revision 48450 works (much better) for me.
Deleting this patch.
http://svn.wxwidgets.org/viewvc/wx/wxWidgets/branches/WX_2_8_BRANCH/src/msw/tbar95.cpp?r1=48449&r2=48450&pathrev=48450

----------------------------------------------------------------------

Comment By: Tim Kosse (botg)
Date: 2007-08-28 22:06

Message:
Logged In: YES 
user_id=156254
Originator: NO

At least in my program, I've put the SetBackgroundColour workaround inside
a check for the used Windows version, so that it still uses the themed
background on vista.

----------------------------------------------------------------------

Comment By: troelsk (troelsk)
Date: 2007-08-28 13:47

Message:
Logged In: YES 
user_id=1290727
Originator: YES


Note:
This attempted solution (calling SetBackgroundColour()->HasBgColor() ->
true) effectively disables the (theme) code in OnEraseBackground, this may
well pose a problem (on Vista?)


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1783181&group_id=9863