[wx-dev] wxHtmlListbox (GetSelectedTextColour) broken in trunk

[Vadim Zeitlin]

On Sun, 02 Mar 2008 16:14:55 +0100 Belgabor <belgabor at gmx.de> wrote:

B> Vadim Zeitlin schrieb:
B> > On Sun, 02 Mar 2008 05:52:33 +0100 Belgabor <belgabor at gmx.de> wrote:
B> > 
B> > B> wxHtmlListbox::GetSelectedTextColour, or rather whatever should call it, 
B> > B> is broken in trunk. My subclass overwrites it and it's never called 
B> > B> (works fine in 2.8.7).
B> > 
B> >  I don't see anything obviously wrong or even obviously different from 2.8
B> > version in the trunk code, could you please check where is it called from
B> > in 2.8 and why this doesn't happen in the trunk?
B> 
B> There is a junk of code that disappeared from the OnDrawItem method.

 I see, thanks. This was an unintended side effect of patch 1650804, I've
now tweaked the code to preserve this patch functionality (use wxRenderer
for native background drawing) but limited it to the case when custom
colours are not used and restored the old code for the case when they are.

 Please let me know if you still have any problems, thanks,
VZ