[ wxwindows-Patches-1894861 ] wxPalm patches for trunk

[SourceForge.net]

Patches item #1894861, was opened at 2008-02-16 11:23
Message generated for change (Comment added) made by vadz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1894861&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Other
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: F,Yh (yhfu)
Assigned to: Vadim Zeitlin (vadz)
Summary: wxPalm patches for trunk

Initial Comment:
There are some patch files to compile the wx for PalmOS SDK 6.1

1. important patches
wx-trunk-out.diff
  some definition of compiling for PalmOS
wx-trunk-pflib.diff
  add path supporting
  update to a new API, deprecate old.
wx-trunk-pflib-missing.diff
  add wider char functions
wx-trunk-makefile-engine.diff 
  update the makefile-engine.mk, add support for "depend". Because there are some errors from make utils when I try to use "-include .dependances" in the makefile. the make utils don't act normal when the ".dependances" file is not exist. So I have to find a way to walk around it.
wx-trunk-makefile.diff
  add new files to the compiling list.


2. optional
wx-trunk-out-add-wxpalm-info.diff
  add the palm platform information
wx-trunk-out-chkconf.diff
  check the configuration for palm
wx-trunk-out-chkconf2.diff
  I insisit that the checktion should move to the include/wx/chkconf.h

wx-trunk-out-confmove.diff
  combine the include files and the definetion of wxConfig, because the definetion of wxConfig depend on the included files.
wx-trunk-out-discuss2.diff
  "#if ! __WXPALMOS5__" is better than "#ifndef __WXPALMOS5__"
  because when __WXPALMOS5__ is not defined or __WXPALMOS5__ is defined as 1, they are all work good, but when __WXPALMOS5__ is defined to 0, which means __WXPALMOS5__ should not be used, then the "#ifndef __WXPALMOS5__" will caused some error.

wx-trunk-out-generic.diff
  There are no file dialog and dir dialog in PalmOS, I use it for testing all of the porting functions.

wx-trunk-out-pacc-error.diff
  the SDK 6.1 have an new compiler PACC, It seems that the compiler have some bugs.


----------------------------------------------------------------------

>Comment By: Vadim Zeitlin (vadz)
Date: 2008-03-02 02:22

Message:
Logged In: YES 
user_id=71618
Originator: NO

Thanks, I've applied most of the patches almost without changes, except
that:

1. I didn't apply chkconf2.diff as it's really out of question to comment
out huge parts of a common file like this. I still don't understand why do
you insist on doing it here (and maybe don't even understand what really do
you insist on, could you please explain (preferably on wx-dev)?): if some
settings must be specifically changed for Palm it should be really done in
wx/palmos/chkconf.h.

2. I also (still) replaced "#if __WXPALMOS__" tests with "#ifdef" ones
(and "#if !" with "#ifndef") as __WXPALMOS[56]__ symbols are either defined
or not and using "#if" to test an undefined symbol is an error with most
compilers and warning with almost all of them at max warning level. Again,
I don't understand your explanation about __WXPAMOS5__ which considers what
happens when it's defined as 0 when my whole point is that it's *never*
defined as 0, it's either defined or not. Using defined/undefined or 0/1 is
just a matter of taste, of course, but for __WX<PORT>__ symbols we use the
former convention (and for wxUSE_XXX ones the latter) and I'd really like
to keep it this way.

Anyhow, thanks a lot for your patches and keep the good work!


P.S. Would you be interested in providing a build slave (i.e. a machine
running automated rebuilds) for wxPalm? This would both increase the
visibility of this port and allow us to check its compilation ourselves (I
know I should install the Palm tool chain here but I still didn't have time
to do it...). Please see
http://www.wxwidgets.org/wiki/index.php/Development:_Buildbot#Setting_up_a_Slave
for more details. TIA!

----------------------------------------------------------------------

Comment By: F,Yh (yhfu)
Date: 2008-02-16 11:37

Message:
Logged In: YES 
user_id=1942131
Originator: YES

File Added: wx-trunk-palmos.tgz

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1894861&group_id=9863