[wx-dev] pImpl file layout

Stefan Csomor csomor at advancedconcepts.ch
Mon Jun 23 10:16:06 PDT 2008


Hi Vadim

On 23.06.08 18:35, "Vadim Zeitlin" <vadim at wxwidgets.org> wrote:

> On Mon, 23 Jun 2008 18:06:39 +0200 Stefan Csomor <csomor at advancedconcepts.ch>
> wrote:
> 
> SC> ie
> SC> 
> SC> src/osx/window.cpp
> SC> src/osx/carbon/windowi.cpp
> SC> src/osx/cocoa/windowi.cpp
> SC> 
> SC> ?
> 
>  This doesn't seem very intelligible to me... If we use a suffix, I'd use
> "impl" or "_impl" to make it clear what does it mean. Alternatively, we
> could use "window.cpp" for the implementation files and window_osx.cpp for
> the first one, which would be more clear too IMO, even if a bit redundant.

impl for me would be fine, the window_osx.cpp would be fine for me as well,
don't you think that this might lead to confusion as in all other ports
window.cpp is the next level in the platform dir ? one advantage for this
latter option would be, that the files in carbon wouldn't have to be renamed
...

so I'm slightly leaning towards the second

Thanks,

Stefan





More information about the wx-dev mailing list