[wx-dev] [ wxwindows-Patches-1858074 ] wxAuiBook RTL improvements under wxGTK

[Tim Kosse]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> IMO we need to fix wxGTK (or wxMSW?) to (not) mirror bitmaps.

Afaik there are two possible solutions to disable mirroring on wxMSW:

1) Setting LAYOUT_BITMAPORIENTATIONPRESERVED. Special care needs to be
taken of wxMemoryDC then though, otherwise text drawn in a memory DC
would be wrongly oriented. Perhaps just set the flag temporarily inside
DrawBitmap?

2) Change wxDC::DrawBitmap to mirror the bitmaps too, so they
effectively get mirrored twice.

> In the worst case we should
> add wxDC::DrawDirectionalBitmap(left, right) which would use
> the right bitmap depending on the RTL support provided by the
> system.

Instead of left and right, I think forward and backward are easier to
understand.

Furthermore, would wxDC::DrawDirectionalBitmap even need a any arguments
other than wxDC::DrawBitmap? Assuming bitmap mirroring is disabled by
default on all platforms, DrawDirectionalBitmap would call DrawBitmap in
LTR locales and would mirror the bitmap in RTL locales.

Tim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHfMOt8N9+lcqiUkURAsD3AKDwxMchw3g5rwfem/VbXgFlbYcygQCg9VC/
nzjW6brXRvt+GqNDpoMXzvk=
=rbyo
-----END PGP SIGNATURE-----