[ wxwindows-Patches-1855678 ] Add wxTB_HORZ_LAYOUT to wxToolBook

SourceForge.net noreply at sourceforge.net
Wed Jan 2 17:25:56 PST 2008


Patches item #1855678, was opened at 2007-12-21 13:05
Message generated for change (Comment added) made by vadz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1855678&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Generic
Group: new feature
>Status: Pending
Resolution: None
Priority: 3
Private: No
Submitted By: dd_ (dd_)
Assigned to: Nobody/Anonymous (nobody)
Summary: Add wxTB_HORZ_LAYOUT to wxToolBook

Initial Comment:
I wanted to use a wxToolBook, but I think that seeing the label under the text takes up too much vertical space, so I added processing of the wxTB_HORZ_LAYOUT flag to allow for the labels to be placed on the right of the icon.
Find the attached file.

----------------------------------------------------------------------

>Comment By: Vadim Zeitlin (vadz)
Date: 2008-01-03 02:25

Message:
Logged In: YES 
user_id=71618
Originator: NO

Hello Jérôme,

I'm sorry, I didn't read the patch correctly and missed that this was
indeed done only if wxTB_HORZ_LAYOUT was passed as a parameter, sorry.

Documentation system is (succintly) described in docs/tech/tn0003.txt. But
basically you just need to add a line to the flags table in tbook.tex.

TIA!

----------------------------------------------------------------------

Comment By: dd_ (dd_)
Date: 2007-12-24 18:08

Message:
Logged In: YES 
user_id=1229443
Originator: YES

Hi,

INHO "orient |= style & wxTB_HORZ_LAYOUT;" is conditional code, since the
flag is set in the toolbar style (orient), only if it is passed as a
parameter ...
I agree it is a good idea to define a new name (even if I think it's a
good idea to have wxBK_HORZ_LAYOUT = wxTB_HORZ_LAYOUT), to avoid later
defining a wxBK_xxx value that is equal to it ...
As for the documentation, is there a document explaining how to add it
(we're getting recursive here, aren't we)?

Cheers,
Jérôme.

----------------------------------------------------------------------

Comment By: Vadim Zeitlin (vadz)
Date: 2007-12-22 15:07

Message:
Logged In: YES 
user_id=71618
Originator: NO

I don't think it's a good idea to do it unconditionally, someone will
certainly prefer the current style.

We need a new flag (wxBK_HORZ_LAYOUT probably) (and documentation for
it).

Could you please modify your patch to work like this? TIA!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1855678&group_id=9863




More information about the wx-dev mailing list