[ wxwindows-Patches-1858926 ] Missing languages in src/common/intl.cpp

[SourceForge.net]

Patches item #1858926, was opened at 2007-12-27 14:26
Message generated for change (Comment added) made by vadz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1858926&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: bug fix
Status: Open
Resolution: None
>Priority: 3
Private: No
Submitted By: Tim Kosse (botg)
Assigned to: Nobody/Anonymous (nobody)
Summary: Missing languages in src/common/intl.cpp

Initial Comment:
The following languages are missing in src/common/intl.cpp:
ka_GE
ku_TR
ne_NP

Patch applies against both WX_2_8_BRANCH as well as trunk.

----------------------------------------------------------------------

>Comment By: Vadim Zeitlin (vadz)
Date: 2008-01-02 21:40

Message:
Logged In: YES 
user_id=71618
Originator: NO

I don't know if "ka_GE" and "ku_TR" should be used instead of just "ka"
and "ku" but why did we lose wxLANGUAGE_SERBIAN? I think we should really
have it and we definitely can't remove it from 2.8 branch...

P.S. To whoever applies the patch: the first change to langcodes.tex
removes a trailing space -- this shouldn't be done, tex2rtf needs it.

----------------------------------------------------------------------

Comment By: Tim Kosse (botg)
Date: 2007-12-30 15:44

Message:
Logged In: YES 
user_id=156254
Originator: YES

Updated patch:

- misc/languages/langtabl.txt updated without the duplicates
- Added Valencian ca_ES at valencia
- fixed misc/languages/genlang.py so that generated stuff matches what's
currently in the generated files (e.g. different syntax in
docs/latex/wx/langcodes.tex)
- Added comments about generated content to intl.h/cpp as it's easy to
miss otherwise.
- Ran genlang.py and pasted the generated code into the target files.

Updated patch tested against both WX_2_8_BRANCH as well as trunk.
File Added: intl-v2.patch

----------------------------------------------------------------------

Comment By: Vaclav Slavik (vaclavslavik)
Date: 2007-12-27 14:35

Message:
Logged In: YES 
user_id=80834
Originator: NO

This is the wrong place to do it, see the comment about this being
generated code in the file (we should probably split generated parts out
into a file of its own...). You have to update the source in misc/languages
instead.

The changes themselves don't look right either. There shouldn't be
duplicate entries for single language -- if e.g. "ne" locale isn't
legitimate (why?!), then only "ne_NP" should be there, not both. If that's
the case, an explanation of the reasons would be useful, too.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1858926&group_id=9863