[ wxwindows-Patches-1858074 ] wxAuiBook RTL improvements under wxGTK

[SourceForge.net]

Patches item #1858074, was opened at 2007-12-25 16:52
Message generated for change (Comment added) made by vadz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1858074&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: bug fix
>Status: Pending
Resolution: None
Priority: 5
Private: No
Submitted By: Tim Kosse (botg)
Assigned to: Nobody/Anonymous (nobody)
Summary: wxAuiBook RTL improvements under wxGTK

Initial Comment:
This patch fixes drawing of the auibook tab art under GTK if using right-to-left languages.

Without the patch, the tabs did't show at all, as seen in the aui sample.

Patches against both WX_2_8_BRANCH as well as trunk are attached.

----------------------------------------------------------------------

>Comment By: Vadim Zeitlin (vadz)
Date: 2008-01-02 21:35

Message:
Logged In: YES 
user_id=71618
Originator: NO

IMO we need to fix wxGTK (or wxMSW?) to (not) mirror bitmaps. Otherwise
any program using arrow-like bitmaps would be confronted to the same
problem. In the worst case we should add wxDC::DrawDirectionalBitmap(left,
right) which would use the right bitmap depending on the RTL support
provided by the system.

But adding #ifdef's like this is just not a good idea, sorry. I'm very
grateful for the work you're doing on improving RTL support in wx but
adding all these #ifdefs can't be the right way to fix this so I really
can't apply the patch in its current form.

----------------------------------------------------------------------

Comment By: Tim Kosse (botg)
Date: 2007-12-25 16:52

Message:
Logged In: YES 
user_id=156254
Originator: YES

File Added: auibook_trunk.patch

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1858074&group_id=9863