[ wxwindows-Bugs-1639815 ] imho predefine flags are a bit mixed up

[SourceForge.net]

Bugs item #1639815, was opened at 2007-01-19 19:46
Message generated for change (Settings changed) made by juliansmart
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=109863&aid=1639815&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Build -- WinCE
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: stas (stishkin)
>Assigned to: Nobody/Anonymous (nobody)
Summary: imho predefine flags are a bit mixed up

Initial Comment:
i am using 2.8.1 widgets
and visual studio 2005. I am trying to compile
widgets for wince, pocket pc 2003 or windows mobile 5.0.

i have followed steps from wxWiki 
http://www.wxwidgets.org/wiki/index.php/Developers_Notebook-WxWinCECompiling

and they worked perfectly for 2.7.* widgets,
however they do not work for 2.8.1 widgets.

In source files in several places predefines state,
for example in include\wx\textctrl.h 
line 470: 
#elif defined(__SMARTPHONE__) && defined(__WXWINCE__)
and project file defines only __WXWINCE__

isn't it that line 470 should be as follows: 
#elif defined(__SMARTPHONE__) || defined(__WXWINCE__)

same type of problems with predefines are in 
textctrl.cpp and textctrlce.cpp




----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=109863&aid=1639815&group_id=9863