[wx-dev] Re: SVN:(SC) [51811] applying patch 1894478

[Stefan Csomor]

Hi Vadim

On 2/15/08 5:30 PM, "Vadim Zeitlin" <vadim at wxwidgets.org> wrote:

> return wxString::Format(_T("Mac OS X (%s %s %s)",
> wxString::FromAscii(name.sysname).
> wxString::FromAscii(name.release).
> wxString::FromAscii(name.machine));

we cannot really be sure as the max size of each fields is _SYS_NAMELEN ,
currently 256, I have searched on any encoding notice for uname, didn't find
any, so the best way to interpret it would be ascii I guess, otherwise it
might have an invalid sequence.. is there an advantage on using
wxString::FromAscii together with wxString::Format vs

    return wxString::Format(_T("Mac OS X (%s %s %s)"),
            name.sysname,
            name.release,
            name.machine);

Thanks for spotting this

Stefan