[wx-dev] Re: SVN:(SC) [51735] adding filename conversion for wxStat

[Stefan Csomor]

Hi Dave

thanks a lot, yes, that way we know fn_str is called in both builds, and on
OS X this is needed, sorry I didn't check the unicode builds

Best,

Stefan


On 2/13/08 9:34 PM, "David Elliott" <dfe at tgwbd.org> wrote:

> Ok..
> 
> I changed this to just use stat instead of wxStat since calling
> fn_str() then feeding it through wxConvFile seems ridiculous.  That
> makes it compile for me. I have no idea if we wanted to add wxStat
> explicitly taking a wxString (instead of wxChar*) which can do
> fn_str() itself or add one explicitly taking a char* (that it can pass
> through directly to the underlying stat) or what really the best
> course of action is here.
> 
> Hopefully someone with more knowledge of this can comment.
> 
> -Dave
> 
> On Feb 13, 2008, at 3:18 PM, David Elliott wrote:
> 
>> Hi Stefan,
>> 
>> With Unicode enabled on the 2.8 branch:
>> 
>> ../wxWidgets/src/common/filename.cpp: In member function Œbool
>> wxFileName::GetTimes(wxDateTime*, wxDateTime*, wxDateTime*) const¹:
>> ../wxWidgets/src/common/filename.cpp:2285: error: cannot convert
>> Œconst wxCharBuffer¹ to Œconst wxChar*¹ for argument Œ1¹ to Œint
>> wxStat(const wxChar*, stat*)¹
>> 
>> On Feb 12, 2008, at 8:16 AM, noreply at wxsite.net wrote:
>> 
>>> Revision: 51735
>>>         http://svn.wxwidgets.org/viewvc/wx?view=rev&rev=51735
>>> Author:   SC
>>> Date:     2008-02-12 05:16:30 -0800 (Tue, 12 Feb 2008)
>>> 
>>> Log Message:
>>> -----------
>>> adding filename conversion for wxStat
>>> 
>>> Modified Paths:
>>> --------------
>>>   wxWidgets/branches/WX_2_8_BRANCH/src/common/filename.cpp
>>> 
>>> 
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: wx-cvs-updates-
>>> unsubscribe at lists.wxwidgets.org
>>> For additional commands, e-mail: wx-cvs-updates-help at lists.wxwidgets.org
>>> 
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: wx-dev-unsubscribe at lists.wxwidgets.org
>> For additional commands, e-mail: wx-dev-help at lists.wxwidgets.org
>> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: wx-dev-unsubscribe at lists.wxwidgets.org
> For additional commands, e-mail: wx-dev-help at lists.wxwidgets.org
> 

-- 

Advanced Concepts AG
Software-Engineering
Heldweg 10   
CH-8475 Ossingen
Switzerland

phone:+41 52 245 0 245
fax:+41 52 245 0 246
http://www.advanced.ch
mailto:csomor at advanced.ch