[ wxwindows-Patches-1874995 ] Patch to xpm files in 2.8 branch

[SourceForge.net]

Patches item #1874995, was opened at 2008-01-18 20:38
Message generated for change (Comment added) made by vadz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1874995&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Common
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 2
Private: No
Submitted By: Tim Stahlhut (stahta01)
Assigned to: Nobody/Anonymous (nobody)
Summary: Patch to xpm files in 2.8 branch

Initial Comment:
This is an patch to add const to the xpm files.
I changed "static char * " to "static const char * ".

Note: Changing to "static const char * const " was NOT possible because it required API changes that would most likely break ABI.

Tim S

----------------------------------------------------------------------

>Comment By: Vadim Zeitlin (vadz)
Date: 2008-02-03 14:46

Message:
Logged In: YES 
user_id=71618
Originator: NO

Thanks, applied to 2.8.

----------------------------------------------------------------------

Comment By: Tim Stahlhut (stahta01)
Date: 2008-01-21 01:25

Message:
Logged In: YES 
user_id=662788
Originator: YES

It removes warnings, when using MinGW GCC 4.x compiler. Ones like this
"null.xpm:30: warning: deprecated conversion from string constant to
'char*'" over two hundred of them compiling artprov sample.

Tim S

----------------------------------------------------------------------

Comment By: Vadim Zeitlin (vadz)
Date: 2008-01-20 23:28

Message:
Logged In: YES 
user_id=71618
Originator: NO

I'm honestly not sure if it's worth applying this patch to the stable
branch. Granted, I don't see how could it break anything but OTOH I don't
see how does it help with anything neither. Does it?

----------------------------------------------------------------------

Comment By: Tim Stahlhut (stahta01)
Date: 2008-01-18 23:53

Message:
Logged In: YES 
user_id=662788
Originator: YES

Forgot to say I did not patch the xpm files under wxPython folder. I also
did not patch the file contrib\samples\ogl\studio\bitmaps\tick.xpm. My text
editor considered tick.xpm an binary file so I could not safely edit it.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1874995&group_id=9863