[wx-dev] [ wxwindows-Patches-1931423 ] Char hook - Edit labels in dialogs

[SourceForge.net]

Patches item #1931423, was opened at 2008-04-01 18:18
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1931423&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Common
Group: new feature
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: arst (arst)
Assigned to: Nobody/Anonymous (nobody)
Summary: Char hook - Edit labels in dialogs

Initial Comment:
After some time, I've completed the patch to enable label editing from tree/list and other controls when used from inside a dialog. 

Background info - (Discussion Vadim, ATS)
http://www.nabble.com/Continued:-Popup-edit-in-a-dialog-td15994114.html
http://article.gmane.org/gmane.comp.lib.wxwindows.general/59141

The patch implements the solution disucussed above. It's been running for some 10 days with no problems. 

EVT_CHAR_HOOK event generation has been changed for these platforms:
- wxGTK: Tested
- wxMSW: Tested
- wxMAC - carbon - Not tested
- wxMOTIF - Not tested
(Have not done: OS/2, Palm, Universal/DFB, more?)

These controls are modified:
1 - wxListCtrl 
  - (Generic, MSW, mac) 
  - tested

2 - wxTreeCtrl 
  - Generic 
  - not tested but very similar to 1

3 - wxDataViewCtrl 
  - Generic
  - not tested but similar to 1.

Maybe someone could give it a test on MAC/Carbon. Also, for DataViewVtrl, it would be nice if it could be checked (Robert?). Motif? 

The patch touches almost 10 files and applies cleanly... not for very long.

I noted that the change to each control is almost identical, and a more efficient approach would be to have a class:

  class wxPopupTextCtrl : public wxTextCtrl { ... }

which handled the EVT_CHAR_HOOK event. Each control would be simplified both with regards to label editing and CHAR_HOOK. That's outside the scope of this patch though. 


Synching with continuously modified SVN has been the biggest problem! I updated all affected files from SVN yesterday.

Regards
// ATS.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1931423&group_id=9863