[ wxwindows-Bugs-1782487 ] MSW: wxToolBar background colour on XP

[SourceForge.net]

Bugs item #1782487, was opened at 2007-08-27 13:13
Message generated for change (Comment added) made by juliansmart
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=109863&aid=1782487&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: wxMSW specific
Group: Platform specific
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Tim Kosse (botg)
Assigned to: Nobody/Anonymous (nobody)
Summary: MSW: wxToolBar background colour on XP

Initial Comment:
Using latest 2.8 branch, default toolbar background colour under Windows XP is incorrect.

This becomes very obvious with for example the Zune theme (http://go.microsoft.com/fwlink/?LinkID=75078)

This can easily be seen in the toolbar sample.

A workaround is to use SetBackgroundColour(wxSystemSettings::GetColour(wxSYS_COLOUR_BTNFACE))

----------------------------------------------------------------------

>Comment By: Julian Smart (juliansmart)
Date: 2007-09-04 13:48

Message:
Logged In: YES 
user_id=59495
Originator: NO

Sorry, I've reverted today's change and now the toolbars are consistently
wxSYS_COLOUR_BTNFACE.

----------------------------------------------------------------------

Comment By: troelsk (troelsk)
Date: 2007-09-04 12:55

Message:
Logged In: YES 
user_id=1290727
Originator: NO


Yes, a toolbar with no controls in it gets this funny shade of gray by
default, just like WordPad.
This is the intent I guess, so maybe it's the better default. 
One can always call mytoolbar->SetBackgroundColour if need be.


----------------------------------------------------------------------

Comment By: Tim Kosse (botg)
Date: 2007-09-04 12:34

Message:
Logged In: YES 
user_id=156254
Originator: YES

Ah, that typo is an additional problem. Fixing the typo fixes the toolbar
sample, but only so because the toolbar sample has controls in its
toolbar.
Try a toolbar which just has tool buttons and separators.

----------------------------------------------------------------------

Comment By: troelsk (troelsk)
Date: 2007-09-04 12:09

Message:
Logged In: YES 
user_id=1290727
Originator: NO


The problem is with the final condition, !!UseBgCol().
It looks like a typo - and removing one '!' makes samples/toolbar good
again.


----------------------------------------------------------------------

Comment By: Tim Kosse (botg)
Date: 2007-09-04 11:48

Message:
Logged In: YES 
user_id=156254
Originator: YES

Agreed, the bug is back.

----------------------------------------------------------------------

Comment By: troelsk (troelsk)
Date: 2007-09-04 11:29

Message:
Logged In: YES 
user_id=1290727
Originator: NO


I think this bug needs reopening:
The change to tbar95.cpp today makes the Zune problem reappear, as seen in
samples/toolbar.
This change had made it into the 2.8.5 stable release being prepared
today.

"r48549/r48548: Apply the background fix only if the toolbar has
controls"

Thanks
Troels


----------------------------------------------------------------------

Comment By: Tim Kosse (botg)
Date: 2007-08-30 09:00

Message:
Logged In: YES 
user_id=156254
Originator: YES

Agreed.

----------------------------------------------------------------------

Comment By: troelsk (troelsk)
Date: 2007-08-30 08:25

Message:
Logged In: YES 
user_id=1290727
Originator: NO


tbar95.cpp revision 48450 appears to fix the Zune toolbar problem, it
works for me.
I think this bug can be closed.
http://svn.wxwidgets.org/viewvc/wx/wxWidgets/branches/WX_2_8_BRANCH/src/msw/tbar95.cpp?r1=48449&r2=48450&pathrev=48450

----------------------------------------------------------------------

Comment By: troelsk (troelsk)
Date: 2007-08-29 08:30

Message:
Logged In: YES 
user_id=1290727
Originator: NO

A few Zune observations:

1. samples/toolbar: Weird toolbar background color (bad BTNFACE controls
background)
2. samples/aui: Weird toolbar background color (bad BTNFACE gripper
control background)
3. samples/aui: Bad active caption colour (active almost impossible to
distinguish from inactive)
4. WordPad: Same weird toolbar background color (control backgrounds looks
ok though)
5. Windows Explorer: BTNFACE toolbar background color

Ad 3: The auidemo sample needs more panels to demonstrate this, patch
auidemo.cpp to get more panels,
http://sourceforge.net/tracker/index.php?func=detail&aid=1736135&group_id=9863&atid=309863


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=109863&aid=1782487&group_id=9863