[ wxwindows-Bugs-1466185 ] array subscript out of range in src/common/db.cpp

[SourceForge.net]

Bugs item #1466185, was opened at 2006-04-07 10:28
Message generated for change (Comment added) made by vadz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=109863&aid=1466185&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Database
Group: Trivial
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Michal Marek (mmarek)
Assigned to: Nobody/Anonymous (nobody)
Summary: array subscript out of range in src/common/db.cpp

Initial Comment:
src/common/db.cpp has (in wxDb::logError()):

errorList[pLast][DB_MAX_ERROR_MSG_LEN];

but wxDb::errorList is declared the following way in
include/wx/db.h:


#ifdef __VMS
   // The DECC compiler chokes when in db.cpp the array
is accessed outside
   // its bounds. Maybe this change should also applied
for other platforms.
    wxChar
errorList[DB_MAX_ERROR_HISTORY][DB_MAX_ERROR_MSG_LEN+1];
#else
    wxChar
errorList[DB_MAX_ERROR_HISTORY][DB_MAX_ERROR_MSG_LEN];
#endif

So either the first declaration should be used on all
platforms (wouldn't it
break binary cmpatibility?), or wxDb::logError() should
write one byte less.
Which solution is preferable?


This was originaly reported by David Binderman at
https://bugzilla.novell.com/show_bug.cgi?id=160786 , I
just forward it here
because it's not a SUSE specific bug.



----------------------------------------------------------------------

Comment By: Vadim Zeitlin (vadz)
Date: 2007-10-25 01:30

Message:
Logged In: YES 
user_id=71618
Originator: NO

We're sorry, but wxODBC is not maintained and has been removed from the
latest wxWidgets versions because of this. We're unfortunately unable to
fix bugs in it, please consider using one of the other open source ODBC
libraries instead.

----------------------------------------------------------------------

Comment By: Jose Cruanyes (cruanyes)
Date: 2006-04-07 11:17

Message:
Logged In: YES 
user_id=950155

was already noted
<http://lists.wxwidgets.org/cgi-bin/ezmlm-cgi?5:mss:
67083:200510:bflmocmgcbbldnoiocdo>


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=109863&aid=1466185&group_id=9863