[wx-dev] Patch to reduce warning in wxMSW using MinGW GCC 3.4.5

[Vadim Zeitlin]

On Mon, 1 Oct 2007 00:08:40 +0000 (UTC) Tim Stahlhut <stahta01 at verizon.net> wrote:

TS> Patch to reduce warning in wxMSW using MinGW GCC 3.4.5.
TS> 
TS> Removes "warning: type attributes are honored only at type definition"
TS> about 54,000 of them.

 I've applied the parts replacing WXDLLEXPORT with WXDLLIMPEXP_FWD_CORE but
I'm less sure about this one:

TS> Index: include/wx/dlimpexp.h
TS> ===================================================================
TS> --- include/wx/dlimpexp.h	(revision 48995)
TS> +++ include/wx/dlimpexp.h	(working copy)
TS> @@ -243,7 +243,7 @@
TS>  
TS>  /* GCC warns about using __attribute__ on forward declarations, so we need
TS>     another set of macros for them: */
TS> -#if defined(HAVE_VISIBILITY)
TS> +#if defined(HAVE_VISIBILITY) || (defined(__WINDOWS__) && defined(__GNUC__))
TS>      #define WXDLLIMPEXP_FWD_BASE
TS>      #define WXDLLIMPEXP_FWD_NET
TS>      #define WXDLLIMPEXP_FWD_CORE

 Is the comment above this change still correct? I.e. AFAIK mingw32 doesn't
support visibility and hence doesn't use __attribute__. Or am I missing
anything?

 Thanks,
VZ