[ wxwindows-Bugs-1815708 ] Can't compile on Solaris 8 SPARC

[SourceForge.net]

Bugs item #1815708, was opened at 2007-10-18 04:29
Message generated for change (Comment added) made by sf-robot
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=109863&aid=1815708&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Build -- unix
Group: Platform specific
>Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Michael Forstner (mike25)
Assigned to: M.J.Wetherell (mweth)
Summary: Can't compile on Solaris 8 SPARC

Initial Comment:
Tried to compile wxMotif 2.8.6 on SUN Solaris 8 (SPARC) with following result:

"../src/common/tarstrm.cpp", line 362: Error: Too many arguments in call to "getpwuid_r(long, passwd*, char*, int)".
"../src/common/tarstrm.cpp", line 384: Error: Too many arguments in call to "getgrgid_r(long, group*, char*, int)".

Accouring to the manpage of getpwuid_r() and getgrgid_r() the prototype looks like this:
struct passwd *getpwuid_r(uid_t uid, struct passwd *pwd, char *buffer, int buflen);

struct group *getgrgid_r(gid_t gid, struct group *grp, char *buffer, int bufsize);

----------------------------------------------------------------------

>Comment By: SourceForge Robot (sf-robot)
Date: 2007-11-14 19:20

Message:
Logged In: YES 
user_id=1312539
Originator: NO

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

----------------------------------------------------------------------

Comment By: Stefan Neis (neis)
Date: 2007-10-31 02:35

Message:
Logged In: YES 
user_id=32202
Originator: NO

Actually, with Solaris 9 it was already working (at least for me) before
that patch: Solaris 9 has both version of those ..._r functions available
and chooses which one to use based on what defines are set
(or not set). At least gcc always chooses its built-in defines so that it
gets the posix conforming
version. With a bit of hacking to CXXFLAGS and CFLAGS, I was able to turn
the functions of completely,
but I was unable to get the version of the functions that caused problems.
So I guess the really interesting test case is really Solaris 8 (which I
don't have available :-( ).

----------------------------------------------------------------------

Comment By: M.J.Wetherell (mweth)
Date: 2007-10-31 01:08

Message:
Logged In: YES 
user_id=1262351
Originator: NO

Thanks for checking.

Regards,
Mike

----------------------------------------------------------------------

Comment By: Michael Forstner (mike25)
Date: 2007-10-31 00:46

Message:
Logged In: YES 
user_id=415807
Originator: YES

Hi,

mweth's patch works for Solaris 9.

Thanks,
Mike

----------------------------------------------------------------------

Comment By: M.J.Wetherell (mweth)
Date: 2007-10-18 09:47

Message:
Logged In: YES 
user_id=1262351
Originator: NO

Hi,

I've changed configure to also check the signatures of
those functions:
http://svn.wxwidgets.org/viewvc/wx?view=rev&revision=49229
so on Solaris 7-9 it should fall back to the non-_r
functions.

I'd appreciate it if Mike or Stefan would test it out
on Solaris 8, patch:
http://svn.wxwidgets.org/viewvc/wx/wxWidgets/branches/WX_2_8_BRANCH/configure?view=patch&r1=49229&r2=49228&pathrev=49229

Thanks,
Mike

----------------------------------------------------------------------

Comment By: Stefan Neis (neis)
Date: 2007-10-18 05:13

Message:
Logged In: YES 
user_id=32202
Originator: NO

Obviously, we're not the first ones to stumble on this, for a possible
patch see e.g.
http://svr5.postgresql.org/pgsql-patches/2004-03/msg00290.php
(and http://svr5.postgresql.org/pgsql-patches/2004-03/msg00323.php
 for a small correction).
[It might be worth to look at the current postgresql source code to see if
there have been further changes to this ...]

If you feel like porting that fix from postgresql to wxWidgets and 
testing it (and submitting it to our patch manager once it works), that
would probably be the fastest way to get the fix included into wx...



----------------------------------------------------------------------

Comment By: Vadim Zeitlin (vadz)
Date: 2007-10-18 04:34

Message:
Logged In: YES 
user_id=71618
Originator: NO

You could try disabling tar streams for now. But this still needs to be
fixed, of course...

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=109863&aid=1815708&group_id=9863