[ wxwindows-Patches-1820582 ] wxListCtrl Iconposition fix

[SourceForge.net]

Patches item #1820582, was opened at 2007-10-26 12:57
Message generated for change (Comment added) made by vadz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1820582&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Generic
Group: optimization
>Status: Pending
Resolution: None
Priority: 5
Private: No
Submitted By: Andre at Softpredict (ic3m4n2005)
Assigned to: Nobody/Anonymous (nobody)
Summary: wxListCtrl Iconposition fix

Initial Comment:
Corrected positioning of icons in Icon and Small_Icon view to solve the disorder of items when using different (longer) iconlabels. Look now matches more Windows and KDE's own explorer style.
Pictures of it are packed together with the patch in zip file.

----------------------------------------------------------------------

>Comment By: Vadim Zeitlin (vadz)
Date: 2007-11-02 01:48

Message:
Logged In: YES 
user_id=71618
Originator: NO

I don't see the difference your patch makes for the "Icons with text" view
in the listctrl sample (could you please provide a patch to the sample
showing the problems in the current code), but I do unfortunately see that
it totally breaks the "Icons" (without text) view -- just try it yourself.

I attach my cleaned up (manually deTABified <sigh>) version of your patch
but it really can't be applied in its current state because of the above
problem -- could you please correct it?

Thanks!
File Added: list.diff

----------------------------------------------------------------------

Comment By: Andre at Softpredict (ic3m4n2005)
Date: 2007-10-31 18:04

Message:
Logged In: YES 
user_id=1921369
Originator: YES

Fixed the problems mentioned und added 2 new pics to show the difference.
Hopefully the hards are gone now, cause i use both windows & linux to work
on my files :)

----------------------------------------------------------------------

Comment By: Andre at Softpredict (ic3m4n2005)
Date: 2007-10-31 18:01

Message:
Logged In: YES 
user_id=1921369
Originator: YES

File Added: listctrl_layout_patch_new.zip

----------------------------------------------------------------------

Comment By: Vadim Zeitlin (vadz)
Date: 2007-10-27 23:11

Message:
Logged In: YES 
user_id=71618
Originator: NO

I'm sorry, I don't understand what do the pictures correspond to. Could
you please describe how to reproduce the problem in the listctrl sample (or
make a small patch doing it)?

Concerning the patch itself, there are 2 problems: first one is cosmetic
but annoying: please don't use hard TABs in wx sources, they need to be
removed manually otherwise and they also complicate patch reading. The
second one is not critical neither but, again, if you don't do I'd have to
do it myself and unfortunately I don't have time for it now: please replace
std::queue usage with wxArray. Not all wx build configurations have working
standard library classes so you should use wxArrays in the library code.

Could you please correct these issues and resubmit the patch?

Thanks in advance!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1820582&group_id=9863