[ wxwindows-Patches-1710807 ] Cannot build with '--disable-intl'

[SourceForge.net]

Patches item #1710807, was opened at 2007-05-01 22:54
Message generated for change (Comment added) made by tijs
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1710807&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Build -- unix
Group: bug fix
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Tijs Michels (tijs)
Assigned to: Nobody/Anonymous (nobody)
Summary: Cannot build with '--disable-intl'

Initial Comment:
The attached patch, albeit trivial, was needed in order to build the current CVS tree with configure option '--disable-intl'.

wx/CVS
GTK


----------------------------------------------------------------------

>Comment By: Tijs Michels (tijs)
Date: 2007-05-02 17:15

Message:
Logged In: YES 
user_id=1259995
Originator: YES

So the wxPLURAL issue has been fixed. Thanks.
As it happens, there is also a tiny issue with

  include/wx/unix/apptrait.h

Method 'wxGUIAppTraits::SetLocale' should definitely
be between '#if wxUSE_INTL ... #endif'.

This is item 1 in the newly attached patch (I removed
the original one, which was obsoleted by Vaclav's fix).

The remainder of the patch is really only meant to point
to other lines that stop a build with '--disable-intl'.
The fixes themselves are haphazard, but they suffice
to localize the problem.

File Added: disable_intl.diff

----------------------------------------------------------------------

Comment By: Vaclav Slavik (vaclavslavik)
Date: 2007-05-02 00:46

Message:
Logged In: YES 
user_id=80834
Originator: NO

> why, post 2.8, the wxPLURAL
> definition was removed from the end of intl.h

It wasn't, of course. It was added to 2.8 branch but not HEAD, apparently
by omission. Anyway, as I said, it's already fixed in CVS now.

----------------------------------------------------------------------

Comment By: Tijs Michels (tijs)
Date: 2007-05-01 23:56

Message:
Logged In: YES 
user_id=1259995
Originator: YES

True, no doubt, but that begs the question why, post 2.8, the wxPLURAL
definition was removed from the end of intl.h. For this much is sure,
currently --I updated my CVS tree this evening-- it is not defined there
outside the '#if wxUSE_INTL' block.

----------------------------------------------------------------------

Comment By: Vaclav Slavik (vaclavslavik)
Date: 2007-05-01 23:21

Message:
Logged In: YES 
user_id=80834
Originator: NO

Defining wxPLURAL in filedlgg.cpp doesn't make sense. This should be done
near the end of intl.h, where _() is defined. I fixed this part properly in
CVS (it was already fixed on 2.8 branch).

Disabling the entire block of code in the other part of the patch, instead
of just replacing wxLocale::GetSystemEncodingName() (the _only_ offending
piece here as far as I can tell) with something reasonable doesn't sound
like a good idea either. It should almost certainly be fixed by just
commenting this call out (so that UTF8 or Latin1 is used below), but
leaving open for somebody more familiar with the code.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1710807&group_id=9863