[wx-dev] [GTK] handling TAB and other navigation keys

Paul Cornett pc-wx at bullseye.com
Sun Mar 25 21:36:07 PDT 2007


Vadim Zeitlin wrote:
>  As usual when touching GTK+ internals I'd appreciate if somebody
> could review my changes, so I attach a diff. The only important
> changes are in src/gtk/window.cpp but you need the entire diff to
> make it compile.

Thanks for looking into this, it seems long overdue. Just a few quick
comments:

src/gtk/popupwin.cpp has a focus handler like the one in
toplevel.cpp, I'm guessing it should also be removed.

In wx_window_focus_callback, it would be simpler to just return
win->GetChildren().empty().

And, the wxLogTrace format spec for the pointers should probably be %p.




More information about the wx-dev mailing list