[ wxwindows-Patches-1729861 ] wxFlexGridSizer fix

[SourceForge.net]

Patches item #1729861, was opened at 2007-06-02 12:25
Message generated for change (Comment added) made by arst
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1729861&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Common
Group: None
Status: Closed
Resolution: Out of Date
Priority: 5
Private: No
Submitted By: arst (arst)
Assigned to: Nobody/Anonymous (nobody)
Summary: wxFlexGridSizer fix

Initial Comment:
Hello,

This patch applies to wxw 2.9.0 (from CVS).

I encountered a crash in wxFlexGridSizer::RecalcSizes() (iterator accessed invalid memory). 

Simple fix, change order of statements in inner loop so that test for null iterator comes before 'continue' (which would skip past end of list).

Tested and working with wxGTK.

Regards
// Arne S.


----------------------------------------------------------------------

>Comment By: arst (arst)
Date: 2007-06-02 19:08

Message:
Logged In: YES 
user_id=1718604
Originator: YES

OK, I hadn't checked CVS the last few days, since I downloaded the file
very recently.

CVS solution looks fine it should.

Another problem that was corrected in my patch:

- GCC 4.1.2 on Linux seems complains if all the constructors are in the
header file.
So I moved wxCBoxSizer::wxBoxSizer( int orient ) into the source file
instead. That
made GCC happy (I've encountered the same before, I think it's a compiler
issue really).

OK
// Arne S.

----------------------------------------------------------------------

Comment By: arst (arst)
Date: 2007-06-02 17:19

Message:
Logged In: YES 
user_id=1718604
Originator: YES

OK, I hadn't checked CVS the last few days, since I downloaded the file
very recently.

CVS solution looks fine it should.

Another problem that was corrected in my patch:

- GCC 4.1.2 on Linux seems complains if all the constructors are in the
header file.
So I moved wxCBoxSizer::wxBoxSizer( int orient ) into the source file
instead. That
made GCC happy (I've encountered the same before, I think it's a compiler
issue really).

OK
// Arne S.

----------------------------------------------------------------------

Comment By: Vadim Zeitlin (vadz)
Date: 2007-06-02 15:03

Message:
Logged In: YES 
user_id=71618
Originator: NO

AFAICS this had already been fixed in the cvs, could you please recheck
that you really see the bug with the latest cvs?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1729861&group_id=9863