[ wxwindows-Bugs-1746278 ] wxDialogBase::ButtonSizerFlags missing flags

[SourceForge.net]

Bugs item #1746278, was opened at 2007-07-02 07:35
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=109863&aid=1746278&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Common
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Marcin Wojdyr (wojdyr)
Assigned to: Nobody/Anonymous (nobody)
Summary: wxDialogBase::ButtonSizerFlags missing flags

Initial Comment:

in include/wx/dialogs.h, in ButtonSizerFlags list, two flags are missing: wxAPPLY and wxCLOSE. 
That was me who posted patch to add Apply and Close to CreateButtonSizer(), and I didn't notice ButtonSizerFlags then. 

diff -u -r1.54 dialog.h
--- dialog.h    2007/06/13 16:29:13     1.54
+++ dialog.h    2007/07/02 05:17:33
@@ -34,7 +34,8 @@
     enum
     {
         // all flags allowed in wxDialogBase::CreateButtonSizer()
-        ButtonSizerFlags = wxOK|wxCANCEL|wxYES|wxNO|wxHELP|wxNO_DEFAULT
+        ButtonSizerFlags = wxOK | wxCANCEL | wxYES | wxNO | wxAPPLY | wxCLOSE
+                           | wxHELP | wxNO_DEFAULT
     };

     wxDialogBase() { Init(); }



BTW, when I was looking in defs.h for possible conflicts when adding these two flags, I noticed that two wxTC flags are the same:
#define wxTC_FIXEDWIDTH       0x0020
...
#define wxTC_LEFT             0x0020
I don't know what wxTabCtrl is, but it at least looks like a mistake.





----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=109863&aid=1746278&group_id=9863