[ wxwindows-Bugs-1635404 ] fix year old FIXME in src/gtk/menu.cpp

[SourceForge.net]

Bugs item #1635404, was opened at 2007-01-14 23:29
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=109863&aid=1635404&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: wxGTK specific
Group: Platform specific
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ralf Gerlich (ralfgerlich)
Assigned to: Nobody/Anonymous (nobody)
Summary: fix year old FIXME in src/gtk/menu.cpp

Initial Comment:
There is a FIXME comment in gtk_menu_clicked_callback() in src/gtk/menu.cpp, lines 608-611 which was added in revision 1.139 of the file, which was over three years ago.

The commented code region messes up the handling of events in menus attached to a menu bar and is specific to wxGTK.

I have some menus which are dynamically set up and therefore do not allow static assignment of IDs. I'm subclassing wxMenu and doing event handling directly in the menu.

The menu is then either used as submenu of a popup menu or as submenu of a menubar, where in the latter case it is updated by MENU_OPEN events.

In case of the popup menu the events arrive at the menu object, while in case of the menu bar they do not, independently of how I set the invoking window pointer.

This is obviously due to that code region and it seems that event handling of normal menus also works without that code section.

Maybe somebody could check whether this code segment can really be removed and remove it.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=109863&aid=1635404&group_id=9863