[wx-dev] Re: CVS: [SC] wxWidgets/src/mac/carbon stattext.cpp, 1.68, 1.69

[Stefan Csomor]

Hi

Fix committed, please retest

Thanks,

Stefan

> Thanks! Here's a patch against the minimal sample that shows the
> problem.
> 
> It essentially recreates just one row from the following screenshot,
> given again here so you have an idea of what it should look like:
> 
> http://www.hockinternational.com/images/wx/WelcomeNormal.tiff
> 
> Let me know if there's anything else I can do!
> 
> Thanks,
> 
> Kevin
> 
> Stefan Csomor wrote:
> > Hi Kevin
> >
> >> Hello Stefan,
> >>
> >> Unfortunately, it appears that this commit broke multi-line
> wrapping.
> >> ...
> >>
> >> The wrapping is being done using the static text Wrap() function,
> >> which inserts the newlines. My guess is that GetBestRect simply
> >> calculates the width on the entire string as if it were not broken
> into multiple lines. If I comment out the new code inserted in this
> commit, everything goes back to normal.
> >>
> >> Let me know if you need any other information. If you need a code
> >> sample I can provide one, but I thought I'd start with a report
> first.
> >
> > Sorry about that, yes please send me at least a snippet to test
> against, because the fix committed was because of another bug report
> (GetBestSize not working correctly for fields with line feeds in it)
> so that I can do proper regression testing.
> >
> > Thanks a lot,
> >
> > Stefan
> >
> >
> > -------------------------------------------------------------------
> --
> > To unsubscribe, e-mail: wx-dev-unsubscribe at lists.wxwidgets.org
> > For additional commands, e-mail: wx-dev-help at lists.wxwidgets.org
> >
> >