[wx-dev] GetNodePtr(), was: [ wxwindows-Bugs-1618449 ] Some warnings under Linux (compile g++ 4.1.2)

[Mattia Barbon]

On Mon, 9 Apr 2007 18:34:21 -0500
"Marcin Wojdyr" <wojdyr at gmail.com> wrote:

  Hi,

> I looked at this problem method again (there is a lot of warnings
> every time I compile my program, so I can't forget about it).
> 
> It seems that the method GetNodePtr() is used only by erase() in
> hashmap.h, line 280:
> Node** node = GetNodePtr( key );
> and than only (*node) is used, so I think it can be replaced by
> GetNode(). The one exception, where node is used without *, is "if(
> !node )", but I think it will work the same with GetNode().

   (*node) = temp;
 
  The whole point of having GetNodePtr() is having an lvalue
to be able to unlink the node from the list.

> On 4/9/07, SourceForge.net <noreply at sourceforge.net> wrote:
> > Bugs item #1618449, was opened at 2006-12-19 00:01
> > Message generated for change (Comment added) made by wojdyr
> > You can respond by visiting:
> > https://sourceforge.net/tracker/?func=detail&atid=109863&aid=1618449&group_id=9863

<big snip>

Regards
Mattia