[ wxwindows-Patches-1446030 ] [2.6] Eliminate wxDisplay's need for multimon.h on MSW

Mon Apr 2 19:20:04 PDT 2007

Patches item #1446030, was opened at 2006-03-08 16:11
Message generated for change (Comment added) made by sf-robot
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1446030&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: MSW specific
Group: bug fix
>Status: Closed
Resolution: None
Priority: 4
Private: No
Submitted By: Olly Betts (olly)
Assigned to: Nobody/Anonymous (nobody)
Summary: [2.6] Eliminate wxDisplay's need for multimon.h on MSW

Initial Comment:
wxDisplay on MSW requires the multimon.h header.  This
isn't included in mingw's w32api headers, so we can't
rely on it being installed.  This situation is also a
blocker for enabling wxDisplay everywhere by default.

The multimon.h header simply provides dummy
implementations of the win32 multiple monitor API for
win95 and NT4 (which predate that API).  This patch
alters wxDisplay to see if the API is available or not,
and if not, it uses suitable alternative values (1
display with the dimensions of the screen).

Michael Hieke has tested it with MSVC7 on win2K and
win95.  I've tested with a linux hosted mingw
crosscompiler on win98.

----------------------------------------------------------------------

>Comment By: SourceForge Robot (sf-robot)
Date: 2007-04-02 19:20

Message:
Logged In: YES 
user_id=1312539
Originator: NO

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

----------------------------------------------------------------------

Comment By: Vadim Zeitlin (vadz)
Date: 2007-03-19 07:45

Message:
Logged In: YES 
user_id=71618
Originator: NO

I did all I could to let someone else do 2.6.4 release ;-) I think it
would be nice to make it as we did a lot of work backporting stuff in 2.6
and it would be a pity if it were completely wasted but I can't guarantee
that it happens because if it does, it will definitely be done not by me.
So this patch is clearly not a huge priority but it might be yet useful.

See also http://thread.gmane.org/gmane.comp.lib.wxwidgets.devel/84258
(Gmane ate my original message for some reason apparently but it's quoted
almost entirely in Matt's reply) for the ongoing discussion.

----------------------------------------------------------------------

Comment By: Olly Betts (olly)
Date: 2007-03-19 07:35

Message:
Logged In: YES 
user_id=14972
Originator: YES

Sorry, I missed your comment that the 2.6 patch didn't apply to the branch
before.

Is there likely to be another 2.6 release?  If there is, I'll try to find
time to update the patch.  If not, I don't see much point...

----------------------------------------------------------------------

Comment By: Vadim Zeitlin (vadz)
Date: 2007-03-18 15:12

Message:
Logged In: YES 
user_id=71618
Originator: NO

As I had written, the patch doesn't apply to 2.6 branch and I'm not sure
how much interest is there in making this work in 2.6 by now anyhow, so
let me mark this as pending and it should close itself in 2 weeks if
nobody submits an updated version of the patch.

Thanks

----------------------------------------------------------------------

Comment By: Olly Betts (olly)
Date: 2006-03-12 16:54

Message:
Logged In: YES 
user_id=14972

Just noticed that Vadim closed this - reopening because of
the 2.6 version of the patch.  I believe Vadim is correct that 
removing a private, non-virtual function is safe, but it
can easily be left in (unused) if preferred.

----------------------------------------------------------------------

Comment By: Olly Betts (olly)
Date: 2006-03-12 16:32

Message:
Logged In: YES 
user_id=14972

Sorry, I think I must have forgotten to check the "yes, I
really wanted to attach this file rather than just specify
it and have you totally ignore it" checkbox, like I usually
seem to.

Here's the 2.6 version of the patch.  Really, this time!

----------------------------------------------------------------------

Comment By: Vadim Zeitlin (vadz)
Date: 2006-03-12 05:49

Message:
Logged In: YES 
user_id=71618

I don't think it breaks backwards compatibility in 2.6,
removing a non virtual private function shouldn't change
anything (nobody can call it from the user code anyhow and
it doesn't change the object layout, unlike a virtual function).

But the patch doesn't apply to 2.6 branch as is so for now
I've only applied it to HEAD. I've also enabled
wxUSE_DISPLAY by default now as, AFAICS, there is no reason
to not do it any longer.

Thanks!

----------------------------------------------------------------------

Comment By: Julian Smart (juliansmart)
Date: 2006-03-11 05:33

Message:
Logged In: YES 
user_id=59495

Unfortunately the change in display.h will break bin compat
so can't be applied as-is to 2.6. I was confused whether
this was for 2.6 or head - the comment implies there's 2
versions (head and 2.6) but I only see one.

----------------------------------------------------------------------

Comment By: Olly Betts (olly)
Date: 2006-03-10 10:12

Message:
Logged In: YES 
user_id=14972

Here's a version of the patch against 2.6.2 (the only
difference is at the top of src/msw/display.cpp).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1446030&group_id=9863