[ wxwindows-Patches-1039456 ] [wxOS2]Popup menu problems

[SourceForge.net]

Patches item #1039456, was opened at 2004-10-03 17:59
Message generated for change (Comment added) made by vadz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1039456&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: OS2 specific
Group: bug fix
>Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Dave Parsons (dwparsons)
Assigned to: Stefan Neis (neis)
Summary: [wxOS2]Popup menu problems

Initial Comment:
Currently popup menus, aka context menus, do not work.
The problems include:-

titles do not display,
title id is already allocated to the menu separator,
menus show in totally the wrong position,
possible to call DoPopupMenu with out of range parameters,
showing a menu enters an infinite loop with 100% cpu usage,
ProcessEvent is called destroying the return value from
HandleMouseEvent.

This patch corrects the above, although the position is
still not quite correct but it is usable.

This patch has been tested on today's cvs 2.5.3 with
various samples including 'menu'.

----------------------------------------------------------------------

>Comment By: Vadim Zeitlin (vadz)
Date: 2007-04-01 17:28

Message:
Logged In: YES 
user_id=71618
Originator: NO

This seems to have been applied ages ago but never closed...

----------------------------------------------------------------------

Comment By: Stefan Neis (neis)
Date: 2004-10-09 21:38

Message:
Logged In: YES 
user_id=32202

Dave,
what exactly do you mean by "the position is still not quite
correct"? Is there a sample where I can easily check it?
My guess would be that line 1975 of  window.cpp should
probably read something like
nY = nHeight - nY -  "height of popup menu", but on the one
hand, I don't know if that's what you consider to be the
problem and on the other, I have no idea how to actually get
that height. :-(

Stefan

----------------------------------------------------------------------

Comment By: Julian Smart (juliansmart)
Date: 2004-10-07 20:36

Message:
Logged In: YES 
user_id=59495

Many thanks -- patch applied, will be checked by Stefan Neis.
Julian

----------------------------------------------------------------------

Comment By: Dave Parsons (dwparsons)
Date: 2004-10-03 18:33

Message:
Logged In: YES 
user_id=970101

Correction: that should read:-
possible to call HandleMouseEvent with out of range parameters.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1039456&group_id=9863