[ wxwindows-Patches-1515213 ] Combo sample improvements

[SourceForge.net]

Patches item #1515213, was opened at 2006-06-30 18:02
Message generated for change (Comment added) made by vadz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1515213&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Demos and samples
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Jaakko Salli (jmsalli)
Assigned to: Włodzimierz Skiba (abxabx)
Summary: Combo sample improvements

Initial Comment:

Summary:

* Moved ODComboBox vs. ComboBox comparison to separate
dialog.
* Added more elementary ODComboBox to the top.
* Pen-style selector items now have varying height
(very simple, only to demonstrate the ability) and
background colour.
* Added lots items to ListCtrl and TreeCtrl popups.
* Some code cleanup and re-organization.



----------------------------------------------------------------------

>Comment By: Vadim Zeitlin (vadz)
Date: 2007-04-01 17:11

Message:
Logged In: YES 
user_id=71618
Originator: NO

This seems to have been applied a long time ago, closing.

----------------------------------------------------------------------

Comment By: Jaakko Salli (jmsalli)
Date: 2006-07-05 07:34

Message:
Logged In: YES 
user_id=1193883


Because wxPenStyleComboBox::OnMeasureItem() was changed. You
can see the artifact in the old sample as well if you change
the method to return 36 instead of 24.


----------------------------------------------------------------------

Comment By: Włodzimierz Skiba (abxabx)
Date: 2006-07-04 17:50

Message:
Logged In: YES 
user_id=652391

But why the same artefact was not shown in "old" version of
the sample? I don't think the usage of this combo was
changed and iirc it contains same items.

?

----------------------------------------------------------------------

Comment By: Jaakko Salli (jmsalli)
Date: 2006-07-04 16:35

Message:
Logged In: YES 
user_id=1193883


I think its a wxPen feature or bug. That is, some pen
patterns look slightly different when drawn at different
coordinates. You can see it more clearly if you increase
width of the pen used to 10 or so. Reason why it appears
only after you move mouse cursor on the item is probably due
to how wxVListBox repaints items when scrolling.


----------------------------------------------------------------------

Comment By: Włodzimierz Skiba (abxabx)
Date: 2006-07-04 11:05

Message:
Logged In: YES 
user_id=652391

I applied your patch to the CVS Head, thanks! There is
however small bug I noticed, which not occured in previous
sample. When I open first "OwnerDrawnComboBox with
owner-drawn items" then list of items is shown. When I
scroll down, I can see "Cross Hatch" entry which is shown in
attached combo1.png. But when I move mouse courser over this
item, it becomes highligted but pattern drawn looks
differently than without highlight (with long line across
item) see attached combo2.png. And finally when I (re)move
selection to other item, it remains with this line and never
returns to original look, see combo3.png. Any idea?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1515213&group_id=9863