[ wxwindows-Patches-1283416 ] improves retrieval of settings witht he current scheme

[SourceForge.net]

Patches item #1283416, was opened at 2005-09-06 23:36
Message generated for change (Comment added) made by vadz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1283416&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Motif specific
Group: bug fix
>Status: Pending
Resolution: None
Priority: 5
Private: No
Submitted By: Riccardo Mottola (rmottola)
Assigned to: Mattia Barbon (mbarbon)
Summary: improves retrieval of settings witht he current scheme

Initial Comment:
the patch modifies settings.cpp to improve the retrieval of the 
colors of the motif widgets, both by setting different colors 
and by trying to retrieve some informations from the partend 
widget and not from a button, as this can lead to quite wrong 
colors, like on IRIX.

The patch was tested on solaris, linux and irix and with 
motif1.2 and motif 2.1

----------------------------------------------------------------------

>Comment By: Vadim Zeitlin (vadz)
Date: 2007-04-01 17:07

Message:
Logged In: YES 
user_id=71618
Originator: NO

It seems the patch can't be applied as is, is anybody interested in
improving/fixing it still after 2.5 years?

----------------------------------------------------------------------

Comment By: Julian Smart (juliansmart)
Date: 2005-09-20 11:19

Message:
Logged In: YES 
user_id=59495

Sorry, this produces mismatched backgrounds e.g. message box
text, find dialog static box (see dialogs sample). RHL 8
(Motif 2 I think).

----------------------------------------------------------------------

Comment By: Mattia Barbon (mbarbon)
Date: 2005-09-11 23:55

Message:
Logged In: YES 
user_id=30305

  Hi,
I have a couple of problems with the patch: one is the hardwired
"GREEN" color for wxSYS_COLOUR_HIGHLIGHTTEXT, which I assume
is an error. The other is using the top level widget to
retrieve wxSYS_COLOUR_BTNFACE, with the comment
"this colour is used for most widgets, not just buttons". This
looks highly suspicious: if most widgets use
wxSYS_COLOUR_BTNFACE to retrieve the background color
maybe they should be corrected: a button is, by definition,
the correct source for wxSYS_COLOUR_BTNFACE.
Please notice that I am not saying this is wrong, just
that it looks suspicious.

  I reworked the patch to duplicate a bit less code. It should
work as the one you submitted except that I removed the
hardwired "GREEN" and reverted the change to
wxSYS_COLOUR_BTNFACE.

Thanks
Mattia


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1283416&group_id=9863