[wx-dev] wxImage scaling patch, useful vs. feature creep

[Robert Roebling]

Vadim Zeitlin wrote:

> Robert Roebling wrote:

[please don't but my mail address in the reply]

> RR> there is a patch for better (higher quality but
> RR> slower) image scaling including docs.
> RR> 
> RR> https://sourceforge.net/tracker/index.php?func=detail&aid=1537065&group_id=9863&atid=309863
> RR> 
> RR> This looks nice, but could be called inappropriate
> RR> featurism. I'm usually thinking that binary size
> RR> if mostly irrelavant and a patch that is potentially
> RR> useful and documented should be applied.
> 
> The binary size is indeed mostly irrelavant. But not always.
> For example, it surely does count for embedded systems.

I was thinkink about that, too.

> And it's true that wxImage is one of the biggest classes in
> wx already and, what worries me more, there are literally no
> bounds for improving and extending it further.

Exactly, but given how useful and ubiquitous image manipulation
has become, I also don't want to remove it or hinder further
additions. Quite the opposite.

> I believe we need to find a way to factor out functionality
> out of it in separate files (or, better yet, loadable modules)

I don't think loadable module are the way to go due to the
usual problems with interface, ABI etc, but either we split
it in another file as you say

> we can do is to split image.cpp, which is currently one of the
> largest files in src/common, in several parts. One containing
> the required stuff and other(s) with more optional things, such
> as scaling, rotation, conversion to grey scale/monochrome,
> RGB <-> HSV and so on.

or we give it a new sublibrary. BTW, as mentioned before, we
should move wxImage to wxBase anyway or create a sublibrary
libwx_image depending only on libwx_base and then maybe 
another one (libwx_image_adv or something) for more exotic
stuff. BTW, moving wxImage away from libwx_core also requires 
removing its incorrect use of wxPalette (last time I looked)
and replace it with different code.

Would, coincidentally, anyone be interested in this work?

  Robert