[wx-dev] Re: Fallout of Patch #1547639 (Menu stock item support)

[Vadim Zeitlin]

On Sun, 03 Sep 2006 21:55:08 +0200 Francesco Montorsi <f18m_cpp217828 at yahoo.it> wrote:

FM> So here are the simple fixes:
FM> 
FM> Index: src/gtk1/menu.cpp
FM> ===================================================================
FM> RCS file: /pack/cvsroots/wxwidgets/wxWidgets/src/gtk1/menu.cpp,v
FM> retrieving revision 1.180
FM> diff -bu2 -r1.180 src/gtk1/menu.cpp
FM> --- src/gtk1/menu.cpp
FM> +++ src/gtk1/menu.cpp
FM> @@ -772,5 +772,5 @@
FM>       if (str.IsEmpty())
FM>       {
FM> -        wxASSERT_MSG(wxIsStockId(GetId()), wxT("A non-stock menu item 
FM> with an empty label?"));
FM> +        wxASSERT_MSG(wxIsStockID(GetId()), wxT("A non-stock menu item 
FM> with an empty label?"));
FM>           str = wxGetStockLabel(GetId(), 
FM> wxSTOCK_WITH_ACCELERATOR|wxSTOCK_WITH_MNEMONIC);
FM>       }
FM> Index: src/motif/menuitem.cpp
...same thing...
FM> Index: src/msw/menuitem.cpp
...same thing...
FM> Index: src/os2/menuitem.cpp
...same thing...
FM> Index: src/univ/menu.cpp
...same thing...

 Not really related to this patch but I can't help wondering if we could
avoid duplicating this code in all ports.

 Regards,
VZ