2.7.2 ok?

[Francesco Montorsi]

Vadim Zeitlin ha scritto:
> On Tue, 31 Oct 2006 13:15:52 +0100 Francesco Montorsi <f18m_cpp217828 at yahoo.it> wrote:
> 
> FM> this is because wxCollapsiblePane is being used and thus its wxWindow is 
> FM> used as parent of a sizer.
> FM> 
> FM> I attached a fix for this in the wxCollapsiblePane patch - maybe I 
> FM> forgot to include it in the patch or it wasn't committed. However I 
> FM> attach it again.
> 
>  I don't believe it was included in the patch.
sorry then


> 
> FM> Index: src/xrc/xh_sizer.cpp
> FM> ===================================================================
> FM> RCS file: /pack/cvsroots/wxwidgets/wxWidgets/src/xrc/xh_sizer.cpp,v
> FM> retrieving revision 1.33
> FM> diff -bu2 -r1.33 src/xrc/xh_sizer.cpp
> FM> --- src/xrc/xh_sizer.cpp
> FM> +++ src/xrc/xh_sizer.cpp
> FM> @@ -189,7 +189,8 @@
> FM>                   (m_parentAsWindow->IsKindOf(CLASSINFO(wxPanel)) ||
> FM>                    m_parentAsWindow->IsKindOf(CLASSINFO(wxFrame)) ||
> FM> +                  m_parentAsWindow->IsKindOf(CLASSINFO(wxWindow)) ||
> FM>                    m_parentAsWindow->IsKindOf(CLASSINFO(wxDialog)))
> FM>                      ), NULL,
> FM> -                wxT("Incorrect use of sizer: parent is not 'wxDialog', 'wxFrame' or 'wxPanel'."));
> FM> +                wxT("Incorrect use of sizer: parent is not 'wxDialog', 'wxFrame', 'wxWindow' or 'wxPanel'."));
> FM>  
> FM>      if (m_class == wxT("wxBoxSizer"))
> 
>  However I also don't think it's the right thing to do. If we allow
> wxWindow here, we should remove all the others (they're wxWindows too!).
ops  - I did not consider that!

> But while I am not sure what exactly is the reason behind this check, it
> might be a bad idea to remove it now, what about using wxPanel instead of
> wxWindow in wxCollapsiblePane instead?
I'll try but it will take some time to do the tests necessary on wxMSW 
and wxGTK.

Francesco