please read: layout using wxSizerFlags

ABX abx at abx.art.pl
Mon Oct 9 14:19:34 PDT 2006


Vadim Zeitlin <vadim at ...> writes:
>  I've added GetDefaultBorder() to wxSizerFlags so please try to not use the
> hard-coded border sizes in the new code (NB: ABX, I don't say this personally
> for you). I've updated almost all generic dialogs to use wxSizerFlags but
> tan out of steam before I could quite finish so you'll still see some hard
> coded borders in the code but please, please, please don't add new ones.

Full +1. In own personal defense (even if it wasn't personal) I would like to
say that I tolerated some hardcoded values waiting for some
device/platform-policy class mentioned since years where important values like
borders could be located. Poor excuse, but well, I had to try...

As for generic and common dialogs I would also like to mention that some rich
text needs review regading hardocded values and perhaps
wxPrinterBase::CreateAbortWindow should reuse some of your new interface.

HTH (and sorry for commenting only and not commiting but that's all from the
phone I can do until tomorrow)

ABX





More information about the wx-dev mailing list