[wx-dev] Fix for Reentrance problems in events (Sockets problem, even more?)

[Kevin Hock]

Hi Albert,

Thanks for your investigation and work. Since the problems that you 
fixed were against the SOC code (or not?) then you should make a patch 
against the SOC branch. Otherwise, if I'm assuming incorrectly, just 
make the patch against whatever code you started with.

Angel has moved in to a new place and got Internet access back the other 
day so hopefully he'll be able to work with you (and your patch) to help 
get these and any other problems resolved.

Again, thank you for your investigation and patch!

Kevin

Albert van Peppen wrote:
> Hi all,
>  
> I've got my socket problems fixed.
>  
> 1) After some investigation it turned out that when using event driven 
> sockets handling, the EventHandler class was called reentrant, which 
> eventualy causes wxYield() to enter a recursive state.
>  
> I did change the eventhandling in such a way that you can specify per 
> event handler wheter or not it is allowed to be reentrant (although i 
> cannot see why it should be reentrant, but since this is the old 
> behaviour i left this to be the default).
>  
> This fixes my problem and i can imagine it can fix sever problems with 
> controls as well (if they are declared non-reentrant).
>  
> 2) I also have put up a way to set the default timeout value for sockets 
> because when i start a wxClient session and there is no server available 
> at that time, the default timeout is set to 10 minutes! (Which is way to 
> long to report a user that the server is not available)
>  
> 3) There where various size problems in the low-level stream and skipc 
> sources. Some i fixed, some are just guarded with an assertion (might be 
> fixed by someone with more time :)) The assertions are in place but 
> after i fixed some forgotten initializations the did not occour anymore.
>  
> Should i post a patch for these issues? And if so, how is the best way; 
> against latest head or against 2_6 branch?
>  
> Regards,
>  
> Albert van Peppen
>