enhancements to wxStackFrame for Linux

[Francesco Montorsi]

Vadim Zeitlin ha scritto:
> On Fri, 03 Nov 2006 19:51:40 +0100 Francesco Montorsi <f18m_cpp217828 at yah=
oo.it> wrote:
> =

> FM> Vadim Zeitlin ha scritto:
> FM> > On Wed, 01 Nov 2006 20:38:28 +0100 Francesco Montorsi <f18m_cpp2178=
28 at yahoo.it> wrote:
> FM> > =

> FM> > FM> I don't see any other solution than moving wxCollapsiblePane in=
 wxCore =

> FM> > FM> or not using it in the assert dialog...
> FM> > =

> FM> >  For me this depends on whether we want to use it in wxLog dialog o=
r not.
> FM> To make wxLog dialog more native, I'd use it there too.
> =

>  We really need to test that it works on at least the major platforms
> though. As long as wxCollapsiblePane was only used in wxAboutDialog it
> wasn't critical but if it makes the log dialog unusable, it would be real=
ly
> bad. So this shouldn't be done for 2.8.
sure; however having wxCollapsiblePane in core will make it possible to =

do that for e.g. 2.8.1 (even if this is not critical too)


> =

> FM> >  To be honest I don't know which is better. I guess it wouldn't so =
bad to
> FM> > have wxCollapsiblePane in the core, what do the other think?
> FM> I think having it in core would be better. Probably this is a change =

> FM> which can be done before 2.8 ?
> =

>  Yes, I think it could be qualified as a bug fix as we need this in order
> to be able to fix wxStackWalker. Also, I don't think moving anything from
> some other library to core can break anything.
right

> =

> FM> I already did it on my local copy so I could submit a patch...
> =

>  Please do. AFAICS it should just modify build/bakefiles/files.bkl and
> change the WXDLLIMPEXP_ADV into WXDLLIMPEXP_CORE, right?
exactly. I'm attaching the patch directly here

> =

> FM> PS: to improve the wxStackFrame under linux no public API changes are =

> FM> required except for moving wxCollapsiblePane in core and possibly add=
 a
> FM> (public) GetExecutablePath() function to wxStandardPaths.
> =

>  I understand the reasons but people *are* going to abuse it...
I think people are already writing on their own a similar function =

(probably buggy/unreliable) in their code anyway.

E.g. such function is in wx FAQ: http://www.wxwidgets.org/docs/faqcmn.htm

and an implementation is proposed here:

http://www.wxwidgets.org/docs/technote/install.htm

> And we're
> going to be known as the library which encourages putting data files in
> /usr/bin...
hmmmm I don't understand this statement, sorry.
Under Unix's wxStandardPaths  I've just put the part of DetectPrefix() =

which detects the executable path (quite reliable under linux for the =

/proc trick) in GetExecutablePath...


Francesco
-------------- next part --------------
Index: build/bakefiles/files.bkl
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /pack/cvsroots/wxwidgets/wxWidgets/build/bakefiles/files.bkl,v
retrieving revision 1.397
diff -bu2 -r1.397 build/bakefiles/files.bkl
--- build/bakefiles/files.bkl
+++ build/bakefiles/files.bkl
@@ -655,4 +655,5 @@
     src/generic/choicbkg.cpp
     src/generic/clrpickerg.cpp
+    src/generic/collpaneg.cpp
     src/generic/combog.cpp
     src/generic/dcpsg.cpp
@@ -689,4 +690,5 @@
     wx/choice.h
     wx/cmndata.h
+    wx/collpane.h
     wx/combo.h
     wx/combobox.h
@@ -984,4 +986,5 @@
     src/gtk/checklst.cpp
     src/gtk/choice.cpp
+    src/gtk/collpane.cpp
     src/gtk/colordlg.cpp
     src/gtk/combobox.cpp
@@ -1032,4 +1035,5 @@
     wx/gtk/checkbox.h
     wx/gtk/checklst.h
+    wx/gtk/collpane.h
     wx/gtk/colordlg.h
     wx/gtk/choice.h
@@ -2638,5 +2642,4 @@
     src/generic/bmpcboxg.cpp
     src/generic/calctrl.cpp
-    src/generic/collpaneg.cpp
     src/generic/datavgen.cpp
     src/generic/datectlg.cpp
@@ -2660,5 +2663,4 @@
     wx/bmpcbox.h
     wx/calctrl.h
-    wx/collpane.h
     wx/dataview.h
     wx/dateevt.h
@@ -2668,5 +2670,4 @@
     wx/generic/bmpcbox.h
     wx/generic/calctrl.h
-    wx/generic/collpaneg.h
     wx/generic/datectrl.h
     wx/generic/dataview.h
@@ -2785,5 +2786,4 @@
     src/gtk/aboutdlg.cpp
     src/gtk/animate.cpp
-    src/gtk/collpane.cpp
     src/gtk/dataview.cpp
     src/gtk/taskbar.cpp
@@ -2793,5 +2793,4 @@
     wx/generic/animate.h
     wx/gtk/animate.h
-    wx/gtk/collpane.h
 </set>
 =

Index: include/wx/collpane.h
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /pack/cvsroots/wxwidgets/wxWidgets/include/wx/collpane.h,v
retrieving revision 1.7
diff -bu2 -r1.7 include/wx/collpane.h
--- include/wx/collpane.h
+++ include/wx/collpane.h
@@ -28,5 +28,5 @@
 #define wxCP_NO_TLW_RESIZE          (0x0002)
 =

-class WXDLLIMPEXP_ADV wxCollapsiblePaneBase : public wxControl
+class WXDLLIMPEXP_CORE wxCollapsiblePaneBase : public wxControl
 {
 public:
@@ -51,8 +51,8 @@
 =

 BEGIN_DECLARE_EVENT_TYPES()
-    DECLARE_EXPORTED_EVENT_TYPE(WXDLLIMPEXP_ADV, wxEVT_COMMAND_COLLPANE_CH=
ANGED, 1102)
+    DECLARE_EXPORTED_EVENT_TYPE(WXDLLIMPEXP_CORE, wxEVT_COMMAND_COLLPANE_C=
HANGED, 1102)
 END_DECLARE_EVENT_TYPES()
 =

-class WXDLLIMPEXP_ADV wxCollapsiblePaneEvent : public wxCommandEvent
+class WXDLLIMPEXP_CORE wxCollapsiblePaneEvent : public wxCommandEvent
 {
 public:
Index: include/wx/generic/collpaneg.h
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /pack/cvsroots/wxwidgets/wxWidgets/include/wx/generic/collpaneg.h=
,v
retrieving revision 1.6
diff -bu2 -r1.6 include/wx/generic/collpaneg.h
--- include/wx/generic/collpaneg.h
+++ include/wx/generic/collpaneg.h
@@ -20,5 +20,5 @@
 =

 // class name
-extern WXDLLIMPEXP_DATA_ADV(const wxChar) wxGenericCollapsiblePaneNameStr[=
];
+extern WXDLLIMPEXP_DATA_CORE(const wxChar) wxGenericCollapsiblePaneNameStr=
[];
 =

 =

@@ -27,5 +27,5 @@
 // -----------------------------------------------------------------------=
-----
 =

-class WXDLLIMPEXP_ADV wxGenericCollapsiblePane : public wxCollapsiblePaneB=
ase
+class WXDLLIMPEXP_CORE wxGenericCollapsiblePane : public wxCollapsiblePane=
Base
 {
 public:
Index: include/wx/gtk/collpane.h
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /pack/cvsroots/wxwidgets/wxWidgets/include/wx/gtk/collpane.h,v
retrieving revision 1.2
diff -bu2 -r1.2 include/wx/gtk/collpane.h
--- include/wx/gtk/collpane.h
+++ include/wx/gtk/collpane.h
@@ -15,5 +15,5 @@
 #include "wx/generic/collpaneg.h"
 =

-extern WXDLLIMPEXP_DATA_ADV(const wxChar) wxCollapsiblePaneNameStr[];
+extern WXDLLIMPEXP_DATA_CORE(const wxChar) wxCollapsiblePaneNameStr[];
 =

 // -----------------------------------------------------------------------=
-----
@@ -21,5 +21,5 @@
 // -----------------------------------------------------------------------=
-----
 =

-class WXDLLIMPEXP_ADV wxCollapsiblePane : public wxGenericCollapsiblePane
+class WXDLLIMPEXP_CORE wxCollapsiblePane : public wxGenericCollapsiblePane
 {
 public: