[wx-dev] Re: enhancements to wxStackFrame for Linux

[Vadim Zeitlin]

On Fri, 03 Nov 2006 19:51:40 +0100 Francesco Montorsi <f18m_cpp217828 at yahoo.it> wrote:

FM> Vadim Zeitlin ha scritto:
FM> > On Wed, 01 Nov 2006 20:38:28 +0100 Francesco Montorsi <f18m_cpp217828 at yahoo.it> wrote:
FM> > 
FM> > FM> I don't see any other solution than moving wxCollapsiblePane in wxCore 
FM> > FM> or not using it in the assert dialog...
FM> > 
FM> >  For me this depends on whether we want to use it in wxLog dialog or not.
FM> To make wxLog dialog more native, I'd use it there too.

 We really need to test that it works on at least the major platforms
though. As long as wxCollapsiblePane was only used in wxAboutDialog it
wasn't critical but if it makes the log dialog unusable, it would be really
bad. So this shouldn't be done for 2.8.

FM> >  To be honest I don't know which is better. I guess it wouldn't so bad to
FM> > have wxCollapsiblePane in the core, what do the other think?
FM> I think having it in core would be better. Probably this is a change 
FM> which can be done before 2.8 ?

 Yes, I think it could be qualified as a bug fix as we need this in order
to be able to fix wxStackWalker. Also, I don't think moving anything from
some other library to core can break anything.

FM> I already did it on my local copy so I could submit a patch...

 Please do. AFAICS it should just modify build/bakefiles/files.bkl and
change the WXDLLIMPEXP_ADV into WXDLLIMPEXP_CORE, right?

FM> PS: to improve the wxStackFrame under linux no public API changes are 
FM> required except for moving wxCollapsiblePane in core and possibly add a
FM> (public) GetExecutablePath() function to wxStandardPaths.

 I understand the reasons but people *are* going to abuse it... And we're
going to be known as the library which encourages putting data files in
/usr/bin...

 Regards,
VZ