[ wxwindows-Patches-1523304 ] [wxOS2]Calendar sample problems

[SourceForge.net]

Patches item #1523304, was opened at 2006-07-16 10:01
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1523304&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: OS2 specific
Group: bug fix
Status: Open
Resolution: None
Priority: 5
Submitted By: Dave Parsons (dwparsons)
Assigned to: Stefan Neis (neis)
Summary: [wxOS2]Calendar sample problems

Initial Comment:
Some while ago the Datepicker was added to the Widgets
sample which highlighted many problems for OS/2 with
the calandar/date controls.

The attached four patches fix the bulk of the problems.
The remaining most significant problem with scrollbars
and refreshing will be the subject of later patches.
Fixing the obvious faults also resulted in the
unexpected bonus of getting the tree control to work at
last.

Calendar.diff
-------------
This patch corrects problems with the calendar control.
Problems addressed here include incorrect drawing
(dc.cpp, region.cpp), positioning (calctrl.cpp),
incorrect style values (choice.cpp, combobox.cpp,
control.cpp) and knock on effects (toolbar.cpp).
Since the change to calctrl.cpp to use
GetBestFittingSize is common, it should be checked on
other ports and #ifdef'ed if it must be.
The change to IsExposed in window was necessary to
allow to change from wx coordinate system to the OS/2
coordinate system. I couldn't find anywhere else where
all the necessary information was available.
Tested with the Calendar, widgets treectrl etc. samples.

Trees.diff
----------
This was spotted along the way and shows as only
measuring the width of the first string in any group.
The seems to be a cross port problem and can be
observed with the treebook page of the notebook sample.

BmpButton.diff
--------------
Also spotted along the way. Simple geometry errors.
Observable with the dialogs sample. OS/2 only.

Linebundle.diff
---------------
A common OS/2 Gpi error message. This is a simple
safety net fix. Probably should be checked is a few
other places also.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=309863&aid=1523304&group_id=9863