[ wxwindows-Bugs-1541321 ] Crash in .../common/filename.cpp

[SourceForge.net]

Bugs item #1541321, was opened at 2006-08-16 16:09
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=109863&aid=1541321&group_id=9863

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: Must fix
Status: Open
Resolution: None
Priority: 5
Submitted By: Otto Wyss (wyo)
Assigned to: Nobody/Anonymous (nobody)
Summary: Crash in .../common/filename.cpp

Initial Comment:
In wxFileName::GetShortcutTarget the statement

    hres = CoCreateInstance(CLSID_ShellLink, NULL, 
CLSCTX_INPROC_SERVER,
                            IID_IShellLink, (LPVOID*) 
&psl);

may return unsuccessful, so it crashes after the 
statements

    if (SUCCEEDED(hres))
    {
        ...
    }
    psl->Release();

since psl is empty. I've fixed it with 

    if (psl) psl->Release();

but I'm not sure if this is the correct solution.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=109863&aid=1541321&group_id=9863