[wx-dev] [all] 2.7.0 and releases organization in general

[Angel Vidal (Kry)]

On Sun, 2006-08-06 at 01:24 +0200, Vadim Zeitlin wrote:
> On Sun, 06 Aug 2006 01:20:00 +0200 "Angel Vidal (Kry)" <kry at amule.org> wrote:
> 
[...]
>  Anyhow, this really depends on what the fixes are. If they're relatively
> small, fix an important problem and you're sure don't break anything else,
> why not. But as you seem to be in Europe I'd personally strongly advice to
> wait with them until the next morning -- commits at 2am more often break
> the release than not, believe the Murphy's law and my personal experience ;-)
> 

Socket fixes, of course. Trivial fix on UDP sockets that fixes a crash
if you try to send data onder certain circunstances (I added a
wxCHECK_RET only, with a message telling the developer where he went
wrong), and this:

http://cvs.wxwidgets.org/viewcvs.cgi/wxWindows/src/common/Attic/gsocket.cpp.diff?r1=1.1.2.2&r2=1.1.2.3&only_with_tag=SOC2006_SOCKETS

Which fixes the not-so-rare possibility that a remote closed socket is
not signaled as such, and keeps firing GSOCK_INPUT events forever (or
until the socket is closed / destroyed). 

as oyu can see in the diff, the change is fairly straighforward: close
the socket and signal an error if recv() returns 0.

From man recv:
RETURN VALUE
       These calls return the number of bytes received, or -1 if an
error occurred. The return value will be 0 when the peer has performed
an orderly shutdown.

So it must be ok. And I have been using that fix on windows, Mac and
unix on my branch for quite a while (almost a month), with no vissible
problems. 

There is a third change I'm not commiting, because it involves bigger
changes that those, even if it fixes a double-free problem on hostname
resolution, but it's fairly rare anyway.


Now, on the social note, I'm in Europe, but that doens't mean I keep
european sleep schedule. After all I'm known by no sleeping at all for
days, or randomly sleep at any hour. So as I kinnda just woke up 4 or 5
hours ago, it should be ok.

Of course, Murphy's law say that, as this is my first
commit-before-a-release, everything will blow up and burn our houses.
But it also says that, if I don't commit, everyone will sudently find
those bugs just as you release and while the first is bad programmer
behaviour caused, the second one is a (serious) bug.



-- 
- Angel Vidal (Kry)
 Lead coder and Main Admin at aMule Project
 Contributor to wxWidgets
 (http://www.amule.org / kry at amule.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.wxwidgets.org/pipermail/wx-dev/attachments/20060806/736e3952/attachment.pgp