[wx-dev] Remove meaningless assert in wxDebugReport/wxStackWalker

Alex Bligh alex at alex.org.uk
Sat Aug 5 00:46:06 PDT 2006


Vadim,

> AB> Or am I just being lazy? :-)
> 
>  I wouldn't say that but I'd like to be a little more prudent here. So I'll
> modify the code to add 2 entries and also keep the assert but with ">="
> instead of "==" (if it's "<" then we're really in some trouble...). Could
> you please close the bug/patch reports which will be addressed by this?

Sure. I think it's just this bug report for the stack-frame parse (plus
the corresponding patch).

>  BTW, speaking of bug reports, what really surprises me however is that you
> didn't complain (yet?)

:-)

 > about the debug warnings like this one:
> 
> [Debug] 23:52:46: Failed to parse line "ffffffffff600000-ffffffffffe00000 ---p 00000000 00:00 0                  [vdso]" in /proc/self/maps.

I haven't seen that one in an assert box, perhaps because I always
cancel the first one. So no complaint (yet :-) )

> This clearly must be fixed as well on 64 bit Linux platforms.

Yes.

>  OTOH I still can see the debug report window perfectly find and laid out
> correctly under amd64. I'm using HEAD and not 2.6 branch but the code is
> the same in both of them so I really have no idea where is it coming from.
> I do know that the problem must be somewhere else and not in this code per
> se.

The layout difference is (I think) at least in part due to font size
differences. I'm pretty sure I replicated it on standard Ubuntu 32 bit
as well as 64 bit. I'm using 2.6 rather than HEAD, perhaps that's
another possible difference. I will try on 2.7 later.

Alex




More information about the wx-dev mailing list