[wx-dev] Remove meaningless assert in wxDebugReport/wxStackWalker

[Vadim Zeitlin]

On Fri, 04 Aug 2006 22:47:07 +0100 Alex Bligh <alex at alex.org.uk> wrote:

AB> Well, I'm not sure it will create any harm doing that because by it's
AB> very nature, if there's a hole, it shouldn't appear on the stack walk.

 The idea is that if it does appear, you know for sure that the stack is
corrupted and this could be valuable information on its own (at least
because it will save you a lot of time trying to understand how did it got
there if you know in advance that you can't trust the stack at all).

AB> Or am I just being lazy? :-)

 I wouldn't say that but I'd like to be a little more prudent here. So I'll
modify the code to add 2 entries and also keep the assert but with ">="
instead of "==" (if it's "<" then we're really in some trouble...). Could
you please close the bug/patch reports which will be addressed by this?


 BTW, speaking of bug reports, what really surprises me however is that you
didn't complain (yet?) about the debug warnings like this one:

[Debug] 23:52:46: Failed to parse line "ffffffffff600000-ffffffffffe00000 ---p 00000000 00:00 0                  [vdso]" in /proc/self/maps.

This clearly must be fixed as well on 64 bit Linux platforms.

 OTOH I still can see the debug report window perfectly find and laid out
correctly under amd64. I'm using HEAD and not 2.6 branch but the code is
the same in both of them so I really have no idea where is it coming from.
I do know that the problem must be somewhere else and not in this code per
se.

 Regards,
VZ